Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions when search product with sku like "42-" #20727

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Exceptions when search product with sku like "42-" #20727

merged 2 commits into from
Feb 10, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jan 28, 2019

Description (*)

Try to search products with end of string like "-" or "-"
The exception error appear Unexpected $end
https://dev.mysql.com/doc/refman/8.0/en/fulltext-boolean.html

Fixed Issues (if relevant)

  1. Exceptions when search product with sku like "42-" #20716: Exceptions when search product with sku like "42-"
  2. Quick search by SKU not working properly #9988 Quick search by SKU not working properly

Manual testing scenarios (*)

1.Enable the MySql as search engine in configuration.
2.Search in the frontend with sku "42-" or "-"
3.No exception appear

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65 Nazar65 requested a review from sivaschenko January 29, 2019 10:35
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4045 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 10, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants