Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] bundle-product-radio-button-misalign #20743

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20519

Description (*)

Fixed Issues (if relevant)

  1. On Bundle product radio button misalign #20518: Bundle product radio button misalign
  2. ...

Manual testing scenarios (*)

  1. Any Bundle product
  2. Click customize and Add to cart button
  3. Radio button misalign

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4041 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @amol2jcommerce , thanks for the backport. Looks like the checkbox button is not aligned properly:
image
Can you please check if the fix should be adjusted for 2.2 version.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your new Magento instance.
Admin access: https://pr-20743.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@amol2jcommerce
Copy link
Contributor Author

Hi @sivaschenko branch updated. please review.

@sivaschenko
Copy link
Member

Hi @amol2jcommerce , thanks, we'll retest

@ghost
Copy link

ghost commented Feb 23, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants