Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inactive admin user token #20772

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jan 29, 2019

Description (*)

Fixed inactive admin user token error.

Fixed Issues (if relevant)

  1. Can not save an inactive Admin User that has no access tokens generated  #16513: Can not save an inactive Admin User that has no access tokens generated

Manual testing scenarios (*)

  1. Log in to Admin Panel
  2. Navigate to "System" -> "Permissions" -> "All Users"
  3. Click on the inactive Admin User
  4. Click "Save User"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @mage2pratik!

Sorry for delay, I was not sure about the logic but when opened the whole file it became clear.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4654 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 9, 2019

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit ce4af9e into magento:2.3-develop Apr 18, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 18, 2019
@mage2pratik mage2pratik deleted the patch-6 branch March 26, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants