Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19942 in 2.2 #20776

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Fixed issue #19942 in 2.2 #20776

merged 2 commits into from
Feb 8, 2019

Conversation

GovindaSharma
Copy link
Contributor

Fixed issue #19942 in 2.2 Reference PR #20142

Description (*)

Fixed issue #19942 in 2.2 Success message is not showing when creating invoice & shipment simultaniously

Fixed Issues (if relevant)

  1. Success message is not showing when creating invoice & shipment simultaniously  #19942: Success message is not showing when creating invoice & shipment simultaniously

Manual testing scenarios (*)

1.Create order from admin panel.
  1. View order at admin panel and Click "create invoice".
  2. Check the checkbox "create shipment" and "Email copy of invoice" while generating invoice. and click submit invoice button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @GovindaSharma. Thanks for collaboration. Your changes are different with the original PR and look like we can have cases when message will be showing twice.

@GovindaSharma
Copy link
Contributor Author

hi @VladimirZaets i have fixed the issue now,it is now same as original PR.Please have a look now.
Thank You

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4142 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 8, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 8, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants