fixes-for-customer-name-twice-desktop #20832

priti2jcommerce · 2019-01-31T08:07:16Z

Description (*)

Magento version 2.3 luma theme
Desktop view

Fixed Issues (if relevant)

Manual testing scenarios (*)

Go to login page after login ,customer full name is present twice one in welcome message and second in drop down

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2019-01-31T08:07:22Z

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

shikhamis11 · 2019-01-31T08:09:24Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-01-31T08:09:27Z

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you

priti2jcommerce · 2019-01-31T08:10:08Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-01-31T08:10:13Z

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

orlangur · 2019-01-31T12:45:25Z

app/code/Magento/Theme/view/frontend/templates/html/header.phtml

@@ -15,7 +15,8 @@ $welcomeMessage = $block->getWelcome();
    case 'welcome': ?>
        <li class="greet welcome" data-bind="scope: 'customer'">
            <!-- ko if: customer().fullname  -->
-            <span class="logged-in" data-bind="text: new String('<?= $block->escapeHtml(__('Welcome, %1!', '%1')) ?>').replace('%1', customer().fullname)">
+            <span><?= $block->escapeHtml(__('Welcome,')) ?></span>


This is not acceptable, translatable message should retain the same.

Hi @orlangur ,

Thanks for the update, made the changes for this.

priti2jcommerce · 2019-04-02T11:36:57Z

Hi @orlangur ,

Any update on this PR?

Thanks,
Priti

orlangur · 2019-04-02T12:29:08Z

app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less

@@ -525,6 +525,9 @@

        .customer-name {
            cursor: pointer;
+            span {
+                display: none;


Why do we need to hide it? Simply eliminate redundant text rendering

made the changes for above

magento-cicd2 · 2019-04-04T07:52:59Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ priti2jcommerce
❌ priti

priti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

m2-assistant · 2019-04-04T08:45:43Z

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team · 2019-04-04T11:34:48Z

Hi @orlangur, thank you for the review.
ENGCOM-4666 has been created to process this Pull Request

priti2jcommerce · 2019-04-05T05:19:40Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-04-05T05:19:43Z

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-04-05T05:20:25Z

Hi @priti2jcommerce, here is your Magento instance.
Admin access: https://i-20832-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

VasylShvorak · 2019-04-10T11:18:35Z

✔️ QA passed

…stomer-name-twice-desktop # Conflicts: # app/code/Magento/Customer/Test/Mftf/Section/StorefrontPanelHeaderSection.xml

…e-desktop

m2-assistant · 2019-04-16T14:11:52Z

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

iGerchak · 2019-07-18T14:06:36Z

@orlangur, it's incorrect fix because if we remove the "Welcome" block, customers will see just drop-down arrow without any text
Example:

orlangur · 2019-08-06T11:23:30Z

@iGerchak please report a new issue referring here.

magento-engcom-team added Area: Design/Frontend Area: Frontend Component: Theme Release Line: 2.3 Partner: Two Jay partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2019

orlangur self-assigned this Jan 31, 2019

orlangur requested changes Jan 31, 2019

View reviewed changes

orlangur requested changes Apr 2, 2019

View reviewed changes

ghost added the Progress: needs update label Apr 2, 2019

priti2jcommerce closed this Apr 4, 2019

priti2jcommerce force-pushed the fixes-for-customer-name-twice-desktop branch from a00fe27 to d7ac52b Compare April 4, 2019 08:45

fixes-for-customer-name-twice-desktop

7ee12b0

priti2jcommerce reopened this Apr 4, 2019

ghost unassigned orlangur Apr 4, 2019

orlangur approved these changes Apr 4, 2019

View reviewed changes

ghost assigned orlangur Apr 4, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 4, 2019

magento-engcom-team added Component: Customer and removed Component: Theme labels Apr 4, 2019

VasylShvorak self-assigned this Apr 10, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 10, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 10, 2019

p-bystritsky self-assigned this Apr 10, 2019

p-bystritsky added 5 commits April 10, 2019 16:43

magento#20832: MFTF test fix.

921f7b9

Merge remote-tracking branch 'mainline/2.3-develop' into fixes-for-cu…

7314d76

…stomer-name-twice-desktop # Conflicts: # app/code/Magento/Customer/Test/Mftf/Section/StorefrontPanelHeaderSection.xml

magento#20832: MFTF test fix.

a2b2aa0

magento#20832: Static test fix.

6c14bd8

Merge branch '2.3-develop-mainline' into fixes-for-customer-name-twic…

d9568f4

…e-desktop

ghost added Progress: accept and removed Progress: extended testing labels Apr 12, 2019

magento-engcom-team mentioned this pull request Apr 16, 2019

On Header customer name appearing twice after login #20830

Closed

magento-engcom-team merged commit d9568f4 into magento:2.3-develop Apr 16, 2019

magento-engcom-team added this to the Release: 2.3.2 milestone Apr 16, 2019

magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2019

ENGCOM-4666: fixes-for-customer-name-twice-desktop #20832

ad95ff9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes-for-customer-name-twice-desktop #20832

fixes-for-customer-name-twice-desktop #20832

priti2jcommerce commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

shikhamis11 commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

priti2jcommerce commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

orlangur Jan 31, 2019

priti2jcommerce Jan 31, 2019

priti2jcommerce commented Apr 2, 2019

orlangur Apr 2, 2019

priti2jcommerce Apr 4, 2019

magento-cicd2 commented Apr 4, 2019

m2-assistant bot commented Apr 4, 2019

magento-engcom-team commented Apr 4, 2019

priti2jcommerce commented Apr 5, 2019

magento-engcom-team commented Apr 5, 2019

magento-engcom-team commented Apr 5, 2019

VasylShvorak commented Apr 10, 2019

m2-assistant bot commented Apr 16, 2019

iGerchak commented Jul 18, 2019 •

edited

Loading

orlangur commented Aug 6, 2019

fixes-for-customer-name-twice-desktop #20832

fixes-for-customer-name-twice-desktop #20832

Conversation

priti2jcommerce commented Jan 31, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Jan 31, 2019

shikhamis11 commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

priti2jcommerce commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

orlangur Jan 31, 2019

Choose a reason for hiding this comment

priti2jcommerce Jan 31, 2019

Choose a reason for hiding this comment

priti2jcommerce commented Apr 2, 2019

orlangur Apr 2, 2019

Choose a reason for hiding this comment

priti2jcommerce Apr 4, 2019

Choose a reason for hiding this comment

magento-cicd2 commented Apr 4, 2019

m2-assistant bot commented Apr 4, 2019

magento-engcom-team commented Apr 4, 2019

priti2jcommerce commented Apr 5, 2019

magento-engcom-team commented Apr 5, 2019

magento-engcom-team commented Apr 5, 2019

VasylShvorak commented Apr 10, 2019

m2-assistant bot commented Apr 16, 2019

iGerchak commented Jul 18, 2019 • edited Loading

orlangur commented Aug 6, 2019

iGerchak commented Jul 18, 2019 •

edited

Loading