Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed apply discount button alignment on checkout page #20837

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20144

iessue fixed #20137 On checkout page apply discount button is not align with input box

Description (*)

On checkout page apply discount button is not align with input box

Manual testing scenarios (*)

  1. add product to cart
  2. and go to checkout page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

cedarvinda and others added 3 commits January 31, 2019 08:22
…not align with input box

iessue fixed magento#20137 On checkout page apply discount button is not align with input box
_payment-options.less updated
@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@torhoehn
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@torhoehn
Copy link
Contributor

torhoehn commented Feb 2, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-20837.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-4090 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 4, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants