Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved swagger response of product attribute option is_default #20913

Merged

Conversation

hiren2615
Copy link

@hiren2615 hiren2615 commented Feb 3, 2019

Fixed Issues (if relevant)

  1. Incorrect Swager Definition for eav-data-attribute-option-interface  #18525: Incorrect Swager Definition for eav-data-attribute-option-interface

Manual testing scenarios (*)

Example : https://MAGENTO-HOST-NAME/rest/all/V1/products/attributes/country_of_manufacture
For above example URL it will give "is_default": true for the default selected country

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hiren-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 3, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Component: Directory Release Line: 2.3 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4114 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @hiren-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Event: mm19in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants