Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #20917 Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section #20920

Closed

Conversation

pankaj-cedcoss
Copy link
Contributor

@pankaj-cedcoss pankaj-cedcoss commented Feb 3, 2019

Fixed #20917 Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section

Preconditions (*)

  1. Magento 2.2
  2. php 7.2

Steps to reproduce (*)

login into admin panel
go to Order grid section from Sales > Orders
Edit any order containing downladable product with "Links can be purchased separately" enabled.
a modal will appear like http://i.imgur.com/MJePtn5.png
now click on configure button, another modal will display and issue will appear

Expected result (*)

expected_result

Actual result (*)

actual_result

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @pankaj-cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@@ -462,6 +462,18 @@ label.mage-error {
}
}

.admin__fieldset{
&.downloadable{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move Downloadable product related styles to the corresponded module instead of Backend

@sidolov
Copy link
Contributor

sidolov commented Feb 18, 2019

@pankaj-cedcoss , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Feb 18, 2019
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @pankaj-cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants