Fixed #20943 No complete validation while creation of attributes.

[pankaj-cedcoss]

Issue #20943 Fixed

Preconditions (*)

1.Magento 2.3
2.PHP 7.2

Steps to reproduce (*)

1.Create an attribute.

$eavSetup->addAttribute(
			\Magento\Catalog\Model\Product::ENTITY,
			'sample_attribute_Test##',
			[
				'type' => 'text',
				'backend' => '',
				'frontend' => '',
				'label' => 'Sample Atrribute',
				'input' => 'text',
				'class' => '',
				'source' => '',
				'global' => \Magento\Eav\Model\Entity\Attribute\ScopedAttributeInterface::SCOPE_GLOBAL,
				'visible' => true,
				'required' => true,
				'user_defined' => false,
				'default' => '',
				'searchable' => false,
				'filterable' => false,
				'comparable' => false,
				'visible_on_front' => false,
				'used_in_product_listing' => true,
				'unique' => false,
				'apply_to' => ''
			]
		);

2. It will be created . (And it should not create since not special chars other than _ allowed).

3.Edit this attribute from admin panel , you will not allow to edit anything in this attribute due to attributeCode validations.

Expected result (*)

1. Programatically created attribute should also be saved like other attributes.

Actual result (*)

1. You will not able to edit sample_attribute_Test## anything due to validations.

[magento-engcom-team]

Hi @pankaj-cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[eduard13]

Duplicate of #20526

[dmytro-ch]

Closing this PR as a duplicate.
Thank you!

[ghost]

Hi @pankaj-cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.