disable add to until page load

[sunilit42]

Description (*)

Open a configurable product having DropDown options
When the page is being loaded, you will notice that the dropdowns has no values
Click Add To Cart button during this time. The page will be reloaded and a notice message "Open a configurable product having DropDown options" will be shown

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ sunilaccorin
❌ Sunil Patel

---

Sunil Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[magento-engcom-team]

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sunilit42]

@orlangur i did changes, please check it again

[sidolov]

Hi @sunilit42 , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

[orlangur]

Again, CSS classes cannot be used as a JavaScript logic selectors. Please check examples in link I posted.

[sunilit42]

@orlangur magento itself using that same class into add to cart js so i am using that
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/view/frontend/web/js/catalog-add-to-cart.js#L23

let me know if still you want to change it

[sunilit42]

@sidolov
what should i need to do it?
can i create new one and close to this one?

[VladimirZaets]

Hi @sunilit42. You have two options.
The first one: add email to Github that is set in git-config (git config --global user.email for look git email)
The second one: set your Github email to git config (use the same command with passing email address as the last parameter) and create new one PR

[sunilit42]

@VladimirZaets

i created new pull request
#21007

[ghost]

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.