Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct $_SERVER variable use #20968

Merged
merged 6 commits into from
Apr 18, 2019
Merged

Remove direct $_SERVER variable use #20968

merged 6 commits into from
Apr 18, 2019

Conversation

dominicfernando
Copy link
Contributor

@dominicfernando dominicfernando commented Feb 4, 2019 •
edited
Loading

Remove direct $_SERVER variable use in Magento\Store\Model\Store

Manual testing scenarios (*)

Disable the Search Engine Optimization = No then code will fall back to this section.

selection_010

Issue

There is no issue. In other places, server variables call via $this->_request->getServer function.

@magento-engcom-team
Copy link
Contributor

Hi @dominicfernando. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Store Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 4, 2019
@larsroettig
Copy link
Member

Hi @dominicfernando,
can you add some test cases and issue?

@orlangur orlangur self-assigned this Feb 4, 2019
@dominicfernando
Copy link
Contributor Author

@larsroettig I have updated the issue.

@larsroettig larsroettig self-assigned this Feb 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4653 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 10, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 10, 2019
@magento-engcom-team magento-engcom-team merged commit 49d5454 into magento:2.3-develop Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @dominicfernando, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2019
@sivaschenko
ENGCOM-4653: Remove direct $_SERVER variable use #20968
6248ef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@larsroettig larsroettig

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Component: Store Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@dominicfernando @magento-engcom-team @larsroettig @VasylShvorak @orlangur @p-bystritsky