-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing php doc params to ConvertSerializedDataToJson class constructor #21033
Add missing php doc params to ConvertSerializedDataToJson class constructor #21033
Conversation
…iComponentGenerator constructor
Hi @maddumarala. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maddumarala,
thank you for your contribution!
Could you please also remove the unused import use Magento\Framework\App\ResourceConnection;
in app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php
.
And add missing throws
tag for \Magento\Ui\Model\UiComponentGenerator::generateUiComponent
method:
@throws \Magento\Framework\Exception\LocalizedException
.
Thank you!
Hello @dmytro-ch , |
Hi @dmytro-ch, thank you for the review. |
Hi @maddumarala, thank you for your contribution! |
…n class constructor #21033
Description (*)
Add missing php doc params to ConvertSerializedDataToJson class constructor.
Number,type of parameters used in PHPDoc comment does not match with ones in respective function
Contribution checklist (*)