Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing php doc cookie class #21054

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Add missing php doc cookie class #21054

merged 2 commits into from
Feb 12, 2019

Conversation

XxXgeoXxX
Copy link
Member

Description (*)

Add missing PHP-Doc to class Magento/Cookie/Helper/Cookie

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Cookie Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 8, 2019
@orlangur orlangur self-assigned this Feb 8, 2019
orlangur
orlangur requested changes Feb 8, 2019
View reviewed changes
app/code/Magento/Cookie/Helper/Cookie.php Outdated
* @param \Magento\Store\Model\StoreManagerInterface $storeManager
* @param array $data
* @param array $data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change alignment back.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4186 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7e74dc9 into magento:2.3-develop Feb 12, 2019
@ghost
Copy link

ghost commented Feb 12, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 12, 2019
@sidolov
ENGCOM-4186: Add missing php doc cookie class #21054
c835820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

@sidolov sidolov sidolov approved these changes

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Cleanup Component: Cookie Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@XxXgeoXxX @magento-engcom-team @orlangur @sidolov