Skip to content

[Backport] A non-numeric value encountered on mass product update when.. #21080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2019
Merged

[Backport] A non-numeric value encountered on mass product update when.. #21080

merged 3 commits into from
Mar 15, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Feb 8, 2019

Original PR #19095

Description (*)

  1. On developer environment a exception: Exception #0 (Exception): Warning: A non-numeric value encountered in /var/www/html/vendor/magento/module-catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml on line 109 is presen

Fixed Issues (if relevant)

  1. A non-numeric value encountered on mass product update when Minimum Qty Allowed in Shopping Cart is used #21073: A non-numeric value encountered on mass product update when Minimum Qty Allowed in Shopping Cart is used
  2. ...

Manual testing scenarios (*)

  • Set Minimum Qty Allowed in Shopping Cart in System -> Configuration for values for different Customer Groups
  • Try access Mass product update attributes action

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65 Nazar65 changed the title Backport A non-numeric value encountered on mass product update when.. [Backport] A non-numeric value encountered on mass product update when.. Feb 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4182 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Mar 4, 2019

Hi @Nazar65 , unfortunately, changes in the original PR were refactored due to backward incompatible changes (introduced new public method in the class marked as @api). You may view these changes in scope of commit: 0fd425f#diff-7cf271ccff40947cf32660a3f0d76e70
Please, adopt current implementation according to changes in 2.3 release line.
Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4182 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 15, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants