Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on edit mode for product repository when adding children #21083

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Turn on edit mode for product repository when adding children #21083

merged 4 commits into from
Apr 11, 2019

Conversation

pedrosousa13
Copy link
Contributor

@pedrosousa13 pedrosousa13 commented Feb 8, 2019

Description (*)

This should fix the issue with the configurable products not having any options with Bulk and Async API. The product was being cached and its extension attributes were empty when trying to add children to a product via Bulk API.

Fixed Issues (if relevant)

  1. The parent product doesn't have configurable product options. #20366: The parent product doesn't have configurable product options

Manual testing scenarios (*)

  1. Install Magento 2.3 with RabbitMQ
  2. Add Sample data
  3. Follow https://devdocs.magento.com/guides/v2.3/rest/tutorials/bulk-configurable-product/config-product-intro.html
  4. If this fix is not there, when you do the step to add the product children, an error is produced saying that the product does not contain any configurable options.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This should fix the issue with the configurable products not having any options with Bulk and Async API.
Related issue: #20366
@magento-engcom-team
Copy link
Contributor

Hi @pedrosousa13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 8, 2019

CLA assistant check
All committers have signed the CLA.

@pedrosousa13
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @pedrosousa13. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @pedrosousa13, here is your Magento instance.
Admin access: https://i-21083-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VladimirZaets VladimirZaets self-assigned this Feb 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4188 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@pedrosousa13 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@pedrosousa13
Copy link
Contributor Author

@VladimirZaets Is there anything else I need to do or is it out of my hands now?

@VladimirZaets
Copy link
Contributor

Hi @pedrosousa13. Thanks for collaboration. We took in progress your PR. Our workflow a little bit difficult than merge PR directly here, on Github. Please wait and if we will need some additional steps from your side we will write. Thank you

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @pedrosousa13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 11, 2019
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this pull request Apr 12, 2019
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants