[Backport] Fix magento root package identification for metapackage installation

[oleksii-lisovyi]

Original pull request: #22116

Description (*)

Fix issue with failing Magento installing process (php bin/magento setup:install) for installation via metapackage, because of issue in root package defining.

Fixed Issues (if relevant)

1. Magento installation via metapackage: checkExtensions fails #21136: Magento installation via metapackage: checkExtensions fails, because isMagentoRoot works incorrectly for installation

Manual testing scenarios (*)

Steps to reproduce could be takes from issue.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @oleksii-lisovyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4211 has been created to process this Pull Request

[ihor-sviziev]

Hi @oleksii-lisovyi,
Could you create PR with the same changes to 2.3-develop branch?

[ihor-sviziev]

Please squash all changes into single commit and force push your chagnes

[ihor-sviziev]

Please revert this changes, It looks incorrect

[ihor-sviziev]

I checked integration tests failures, looks like we have some legacy test there. I'll discuss what to do with it with @buskamuza. For now no action items needed.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4211 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

Before:

After:

[nmalevanec]

@oleksii-lisovyi, please check failed integration test Magento\Framework\Composer\ComposerInformationTest::testGetRequiredExtensions with data set "Skeleton Composer" ('testSkeleton')
Failed asserting that an array contains 'intl'.

[ihor-sviziev]

Hi @nmalevanec,
It looks like these tests are too old and incorrect.
I wasn’t able to find you in slack. Could you write me a message and let’s discuss what to do with it?

[sivaschenko]

@oleksii-lisovyi @ihor-sviziev is there a related pull request to 2.3-develop?

[oleksii-lisovyi]

@sivaschenko, here it's: #22116

[ihor-sviziev]

Hi @oleksii-lisovyi,

Right now backport looks really different than original PR.
Could you update this PR with changes that were done there?

Thank you!

[sidolov]

@oleksii-lisovyi , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @oleksii-lisovyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.