Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests breaking when upgrading from 2.2 to 2.3 #21165

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix tests breaking when upgrading from 2.2 to 2.3 #21165

merged 1 commit into from
Feb 14, 2019

Conversation

navarr
Copy link
Member

@navarr navarr commented Feb 12, 2019

Due to case sensitivity, when upgrading from 2.2 to 2.3 MFTF tests relying on AdminOrderFormActionSection break.

@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Feb 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4263 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit a764a5c into magento:2.3-develop Feb 14, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @navarr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 14, 2019
@sidolov
ENGCOM-4263: Fix tests breaking when upgrading from 2.2 to 2.3 #21165
a3a994a
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Component: Sales Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@navarr @magento-engcom-team @sivaschenko @okolesnyk