Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation for comment tag #21175

Conversation

yogeshsuhagiya
Copy link
Member

Description (*)

Added translation for <comment> tag and also added translation key.
Goto: STORES > Configuration > SALES > Sales > Minimum Advertised Price > Enable MAP

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @yogeshsuhagiya. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@yogeshsuhagiya
Copy link
Member Author

Hello @magento-engcom-team, can you please take a look into this PR?

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4315 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 0006f5c into magento:2.3-develop Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @yogeshsuhagiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants