Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ForwardPort] #18896 Add Mexico Regions #21180

Merged

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Feb 13, 2019

Description (*)

#18896 : Add Mexican Regions 2.2

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to checkout page
  2. Select Mexico on address form
  3. See mexican regions as options on region select

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Directory Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels Feb 13, 2019
@osrecio osrecio mentioned this pull request Feb 13, 2019
4 tasks
@osrecio osrecio force-pushed the FP_18896_AddMexicoStates branch from ee05dcf to 641f3ed Compare February 13, 2019 09:27
@osrecio osrecio force-pushed the FP_18896_AddMexicoStates branch from 641f3ed to d09b512 Compare February 13, 2019 09:31
@miguelbalparda miguelbalparda self-assigned this Feb 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-4242 has been created to process this Pull Request

@nmalevanec nmalevanec self-assigned this Mar 13, 2019
@nmalevanec nmalevanec force-pushed the FP_18896_AddMexicoStates branch from 1b8407d to 0605d38 Compare March 13, 2019 17:16
@ghost ghost added the Progress: accept label Mar 14, 2019
@magento-engcom-team magento-engcom-team merged commit 12c2a1d into magento:2.3-develop Mar 16, 2019
@ghost
Copy link

ghost commented Mar 16, 2019

Hi @osrecio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants