Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 18761 #21189

Merged

Conversation

DenisSaltanahmedov
Copy link
Contributor

Bug with REPLACE method in Advanced Prices in CSV Import

Fixed Issues

  1. Bug with REPLACE method in Advanced Prices in CSV Import  #18761: Bug with REPLACE method in Advanced Prices in CSV Import

Manual testing scenarios

  1. Define bunch size as e.g 100 (probably 100 is default)
  2. Prepare CSV with over 100 records (I had 2012) and different SKU! E.g 4-5 prices for one SKU
  3. Select the "Replace" method
  4. Make an import

Contribution checklist (*)

  • [*] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @DenisSaltanahmedov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: AdvancedPricingImportExport Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 13, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21189.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4281 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 7, 2019

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Mar 7, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop March 11, 2019 22:19
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop March 11, 2019 22:19
@magento-engcom-team magento-engcom-team merged commit 6692e08 into magento:2.3-develop Mar 16, 2019
@ghost
Copy link

ghost commented Mar 16, 2019

Hi @DenisSaltanahmedov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 16, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants