Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Backend: Fixed checkbox alignment #21221

Closed

Conversation

speedy008
Copy link
Contributor

Original Pull Request

#19631

Description (*)

Checkbox alignment issue backend.

Fixed Issues (if relevant)

  1. Checkbox alignment issue backend. #19630: Checkbox alignment issue backend.

Manual testing scenarios (*)

  1. Login into admin panel > System > Export > checkbox alignment issue "Fields Enclosure".

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@speedy008 speedy008 force-pushed the 2.2-develop-PR-port-19631 branch from 1d0c63d to 64a3ee3 Compare February 14, 2019 08:55
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @speedy008

Why did you not use the same variable as in the original PR?
What is the reason you modify the test?

replace css value Variable
@speedy008
Copy link
Contributor Author

@rodrigowebjump I have created Back-port PR using porting tool. I will check with Original PR nd update it soon.

/**
* @inheritdoc
*/
protected function _fill(array $fields, SimpleElement $element = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide more information about this change, please? I'm not sure it should be included as a part of the backport. Correct me if I'm wrong. Thank you

@rogyar
Copy link
Contributor

rogyar commented Feb 20, 2019

Thank you for your collaboration. Starting from Feb 19 minor style fixes are considered as "Cleanup" and no longer accepted for 2.2-develop branch.

@rogyar rogyar closed this Feb 20, 2019
@ghost
Copy link

ghost commented Feb 20, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Ctucker9233
Copy link

@rogyar Please explain this logic. Is 2.2 at EOL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants