-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Backend: Fixed checkbox alignment #21221
[Backport] Backend: Fixed checkbox alignment #21221
Conversation
1d0c63d
to
64a3ee3
Compare
Hi @speedy008. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @speedy008
Why did you not use the same variable as in the original PR?
What is the reason you modify the test?
replace css value Variable
@rodrigowebjump I have created Back-port PR using porting tool. I will check with Original PR nd update it soon. |
/** | ||
* @inheritdoc | ||
*/ | ||
protected function _fill(array $fields, SimpleElement $element = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide more information about this change, please? I'm not sure it should be included as a part of the backport. Correct me if I'm wrong. Thank you
Thank you for your collaboration. Starting from Feb 19 minor style fixes are considered as "Cleanup" and no longer accepted for 2.2-develop branch. |
Hi @speedy008, thank you for your contribution! |
@rogyar Please explain this logic. Is 2.2 at EOL? |
Original Pull Request
#19631
Description (*)
Checkbox alignment issue backend.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)