Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed issue Unable to open URL for downloadable product #21262

Merged

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#19996
Fixed issue Unable to open URL for downloadable product #18944
Preconditions (*)

  1. Magento V2.2.6 Clean Install.
  2. PHP 7.0.28
  3. No special caching is present.

Steps to reproduce (*)

  1. Create downloadable product.
  2. Add a link to this product, for example https://google.com
  3. Save product.
  4. Order product in front-end.
  5. After order status complete navigate to your downloadable products in front-end.
  6. Click the button to open the URL set in step 2 to download your product.

Expected result (*)

A new page of https://google.com is opened and shown in browser.

Actual result (*)

Page is not opened correctly and error by Magento is thrown:
Something went wrong while getting the requested content.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4297 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-21262.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants