Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed Custom option price calculation is wrong with multi currency when option price type is percentage #21263

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#19608

Description (*)

We have set multi currency custom option with percentage price type now it is working with multi currency switcher.

Fixed Issues (if relevant)

  1. Custom option price calculation is wrong with multi currency when option price type is percentage.  #19561:Custom option price calculation is wrong with multi currency when option price type is percentage

Manual testing scenarios (*)

  1. Set Currency Rates in Magento from Stores > Currency Rates ( Ist -> 70.09, Usd -> 1)
  2. Goto Catalog > Product and edit any Simple product.
  3. Set custom option typed ‘dropdown’ and add options with Price type ‘percentage’.
  4. Go to Front end product details page in which you have created custom options.
  5. Change currency from Currency drop down. and now you will get correct price of the custom option.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

miguelbalparda commented Feb 15, 2019

I keep seeing you doing backports for other people's PRs, have you talked with them about that @amol2jcommerce?

@VladimirZaets VladimirZaets self-assigned this Feb 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4292 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-21263.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2019
…g with multi currency when option price type is percentage #21263
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants