Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span tag for more swatches link #21301

Merged
merged 2 commits into from
Feb 19, 2019
Merged

span tag for more swatches link #21301

merged 2 commits into from
Feb 19, 2019

Conversation

Amadeco
Copy link

@Amadeco Amadeco commented Feb 18, 2019 •
edited
Loading

Good afternoon,

In our case, when you want to do a modification for this element, with by example, in using .lib-button-icon utility mixin, you can not hide the text without hiding icon.

You can not hide text in html tag without before and after pseudo-elements.

I needed to change directly the "More" dictionnary string, before, by adding html tag in it.

This modification purpose to not use js mixins.

Ilan PARMENTIER

span tag for more swatches link
c447cfb 
Good afternoon,

You can not hide text without before and after pseudo-elements.
In our case, when you want to do a modification to a theme for this element, with by example, .lib-button-icon utility mixin, you can not hide the text without hiding icon.

I needed to change directly the "More" dictionnary string.

Ilan PARMENTIER
@magento-engcom-team
Copy link
Contributor

Hi @mageho. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa Karlasa self-assigned this Feb 18, 2019
@Karlasa
Copy link
Contributor

Karlasa commented Feb 18, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21301.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Karlasa
Karlasa suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have little typo there, could you fix it?

Typo error
f53eee0 
change comma
@Amadeco
Copy link
Author

Amadeco commented Feb 18, 2019

@Karlasa done

@Karlasa
Copy link
Contributor

Karlasa commented Feb 18, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21301.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor

Karlasa commented Feb 18, 2019

@mageho
Thank for typo fix,
In generally good idea 👍

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4310 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@mageho thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Feb 19, 2019

Hi @mageho, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit f53eee0 into magento:2.3-develop Feb 19, 2019
magento-engcom-team pushed a commit that referenced this pull request Feb 19, 2019
@sidolov
ENGCOM-4310: span tag for more swatches link #21301
e66d2a1
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlasa Karlasa Karlasa approved these changes

Assignees

@Karlasa Karlasa

Labels
Area: Frontend Component: Swatches Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Amadeco @magento-engcom-team @Karlasa