Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Minimum Qty Allowed in Shopping Cart not working on related product #21317

Merged
merged 1 commit into from
Feb 23, 2019
Merged

[Backport] Minimum Qty Allowed in Shopping Cart not working on related product #21317

merged 1 commit into from
Feb 23, 2019

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#19566

Description (*)

Solve Minimum Qty Allowed in Shopping Cart not working on related products

Manual testing scenarios (*)

  1. Let's take two simple products Product A and Product B
  2. Set Minimum Qty Allowed in Shopping Cart = 10 in Product A from
    Advanced Inventor->Minimum Qty Allowed in Shopping Cart
  3. Assign Product A as a related product in Product B
  4. Open PDP page of Product B
  5. Check Product A checkbox from Related Products block on PDP
  6. Add to cart Product B

Expected result (*)

Add to cart Product A with Qty = 10

Actual result (*)

  1. Add only 1 qty of Product A to the cart
  2. Showing error "We don't have as many of some products as you want."

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Feb 19, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21317.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4323 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9dccad1 into magento:2.2-develop Feb 23, 2019
@ghost
Copy link

ghost commented Feb 23, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants