-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout Page Cancel button is not working #21327 #21356
Checkout Page Cancel button is not working #21327 #21356
Conversation
- hide cancel button if billing address is not available on current quote
Hi @Jitheesh. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Jitheesh. Thank you for your request. I'm working on Magento instance for you |
Hi @Jitheesh, here is your new Magento instance. |
- Code style issues fixed
@Jitheesh - thank you for your PR and fix. |
Hi @miguelbalparda, thank you for the review. |
Hi @Jitheesh, thank you for your contribution! |
Description
Checkout billing cancel button is not required if billing address is not available with current quote. Currently this 'Cancel' button is visible and not functional.
Steps for replicating issue:
Fixed Issues (if relevant)
Manual testing scenarios (*)
Add virtual product to checkout as Guest user without any saved billing address
1.1. Cancel button will be hidden on checkout page
Add virtual product to basket as guest user
2.1. Add billing address and click update button
2.2 Billing address form will be changed to HTML address with edit button,.
2.3 Click Billing address edit button
2.4 Billing address form will be displayed with cancel button, cancel button will help to move back to previous state
Add virtual product to checkout as logged in user with saved address
3.1. Checkout page will load with customer saved billing address
3.3. Choose new address option from address drop down
3.4 Billing address form will be displayed with Cancel button
Contribution checklist (*)