Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Page Cancel button is not working #21327 #21356

Conversation

Jitheesh
Copy link
Contributor

@Jitheesh Jitheesh commented Feb 20, 2019

Description

Checkout billing cancel button is not required if billing address is not available with current quote. Currently this 'Cancel' button is visible and not functional.

Steps for replicating issue:

  1. Add virtual product to basket as guest user
  2. Checkout page will show input fields for adding billing address with update & Cancel buttons
  3. Update button will save billing address, but Cancel button is not doing anything
  4. If you update billing address and then click edit button, it will re-open billing address fields, at this time cancel button is functional. It will hide billing fields and help to go back to previous state.
  5. If you are logged in user with saved address, cancel button will work

Fixed Issues (if relevant)

  1. Checkout Page Cancel button is not working #21327: Checkout Page Cancel button is not working

Manual testing scenarios (*)

  1. Add virtual product to checkout as Guest user without any saved billing address
    1.1. Cancel button will be hidden on checkout page

  2. Add virtual product to basket as guest user
    2.1. Add billing address and click update button
    2.2 Billing address form will be changed to HTML address with edit button,.
    2.3 Click Billing address edit button
    2.4 Billing address form will be displayed with cancel button, cancel button will help to move back to previous state

  3. Add virtual product to checkout as logged in user with saved address
    3.1. Checkout page will load with customer saved billing address
    3.3. Choose new address option from address drop down
    3.4 Billing address form will be displayed with Cancel button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- hide cancel button if billing address is not available on current quote
@magento-engcom-team
Copy link
Contributor

Hi @Jitheesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Jitheesh
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Jitheesh. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Jitheesh, here is your new Magento instance.
Admin access: https://pr-21356.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@miguelbalparda miguelbalparda self-assigned this Feb 20, 2019
@vpodorozh vpodorozh self-requested a review February 23, 2019 12:40
@vpodorozh
Copy link
Contributor

@Jitheesh - thank you for your PR and fix.
It would be awesome if you would cover this functionality with MFTF.
Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-4376 has been created to process this Pull Request

@ghost
Copy link

ghost commented Mar 4, 2019

Hi @Jitheesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants