Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Fixing the Products grid with default values on multi stores #21363

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Feb 20, 2019

Description (*)

This PR fixes the products grid to use the default values on multi storing website.

Fixed Issues (if relevant)

  1. Products grid in admin does not display default values? #13338: Products grid in admin does not display default values?
  2. ...

Manual testing scenarios (*)

  1. Make sure you have a product
  2. Make sure you have several store views
  3. Set a different value for Product Name for each store view

For more details, check task's steps.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4342 has been created to process this Pull Request

@rogyar
Copy link
Contributor

rogyar commented Feb 20, 2019

For QA
This change might affect different product data providers such as CrossSell, UpSell, Grouped Products, Custom Options etc. This change should not bring unexpected behavior since if the data provider is store-related, the corresponding store view is set within a scope of getData method. However, all cases need to be tested.

@sivaschenko
Copy link
Member

Hi @eduard13 we are not able to reproduce the issue on vanilla 2.3-develop. Are you able to reproduce it on the latest codebase and are there any specific steps that should be made?

@eduard13
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your Magento instance.
Admin access: https://i-21363-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@eduard13
Copy link
Contributor Author

@sivaschenko yes, I was able to reproduce it on vanilla. Please make sure you use a different store view for your store, as example:
Having 2 store views for the same store:

  • Default
  • French

The French is set as default (most probably this is the missed part):
xnip2019-02-25_16-44-55

Then just set the product name for French store view, and check the products grid.
Let me know if any additional info is required.
PS: You still can check the current instance.
Thanks.

@ghost
Copy link

ghost commented Mar 4, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 4, 2019
@eduard13 eduard13 deleted the 2.3-develop-13338-issue branch January 11, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants