Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3]creating customer without password is directly confirmed 14492 #21394

Merged
merged 3 commits into from
Jun 7, 2019
Merged

[2.3]creating customer without password is directly confirmed 14492 #21394

merged 3 commits into from
Jun 7, 2019

Conversation

novikor
Copy link
Contributor

@novikor novikor commented Feb 21, 2019

Description (*)

Now, customer account is not confirmed when created without password;
Account IS confirmed if customer follows create/forgot password link

Fixed Issues (if relevant)

  1. Creating Customer without password is directly confirmed #14492: Creating Customer without password is directly confirmed

Manual testing scenarios (*)

Admin Panel

  1. 'Require Emails Confirmation' is set to 'Yes'.
  2. Admin creates account for the Customer in Admin Panel.
  3. The Customer receives email with ask to change password for newly created account.
  4. The Customer does not receive email for account confirmation.
  5. The Customer successfully changes password for the account. The account becomes confirmed.
  6. The Customer tries to login.
  7. The Customer able to login for his/her account.

Frontend
Case 1

  1. 'Require Emails Confirmation' is set to 'Yes'.
  2. The Customer registers account with frontend registration.
  3. The Customer receives confirmation email.
  4. The Customer does not confirm account.
  5. The Customer tries to login.
  6. The Customer can not login and receive message 'This account is not confirmed. Click here to resend confirmation email.'.
  7. The Customer tries to reset his/her password with'forgotpassword' functionality.
  8. The Customer receives email for password reset procedure and use link from email.
  9. The Customer changes his/her password. The account becomes confirmed.
  10. The Customer tries to login.
  11. The Customer able to login for his/her account.

Case 2

  1. 'Require Emails Confirmation' is set to 'Yes'.
  2. The Customer registers account with frontend registration.
  3. The Customer receives email for account confirmation and use link from email.
  4. The Customer confirms account.
  5. The Customer tries to login.
  6. The Customer able to login for his account.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@novikor novikor requested a review from swnsma February 21, 2019 20:47
@magento-engcom-team
Copy link
Contributor

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 21, 2019
@novikor novikor mentioned this pull request Feb 22, 2019
Closed
4 tasks
@swnsma swnsma changed the title [FP 2.2 -> 2.3]creating customer without password is directly confirmed 14492 [2.3]creating customer without password is directly confirmed 14492 Feb 22, 2019
swnsma
swnsma requested changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @novikor,

  1. Please check my comments.
  2. Please check failed tests.

@novikor
Copy link
Contributor Author

novikor commented Feb 24, 2019

Hi @novikor,

  1. Please check my comments.
  2. Please check failed tests.

Done. Please recheck.

swnsma
swnsma requested changes Mar 16, 2019
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please proceed with minor changes.

app/code/Magento/Customer/Model/ForgotPasswordToken/GetByToken.php Outdated
use Magento\Framework\Phrase;

/**
* Class GetByToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating class name in the comment is redundant. Clear responsibility description is sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot agree, but fixed.

@novikor novikor force-pushed the 2.3-Creating-Customer-without-password-is-directly-confirmed-14492 branch from 66932da to 07104e7 Compare March 18, 2019 08:12
@novikor
Copy link
Contributor Author

novikor commented Mar 23, 2019

@swnsma , please review

@novikor novikor requested a review from swnsma March 23, 2019 10:01
@novikor novikor force-pushed the 2.3-Creating-Customer-without-password-is-directly-confirmed-14492 branch 2 times, most recently from edd02a0 to 67f565b Compare March 23, 2019 11:14
@novikor novikor force-pushed the 2.3-Creating-Customer-without-password-is-directly-confirmed-14492 branch from 67f565b to a6fde92 Compare March 25, 2019 09:05
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-4581 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 28, 2019
@sivaschenko
Copy link
Member

Hi @novikor can you please update your branch and resolve conflicts

@ghost ghost removed the Progress: accept label Apr 28, 2019
@novikor
Copy link
Contributor Author

novikor commented May 4, 2019

Hi, @sivaschenko . Sorry for the delay.
The branch is up to date with 2.3-develop now.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@novikor novikor force-pushed the 2.3-Creating-Customer-without-password-is-directly-confirmed-14492 branch from 50415fe to 4e11099 Compare May 16, 2019 08:34
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 7, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 1ff6e0f into magento:2.3-develop Jun 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 7, 2019
@p-bystritsky
ENGCOM-4581: [2.3]creating customer without password is directly conf…
4033888 
…irmed 14492 magento#21394
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

Assignees

@swnsma swnsma

@p-bystritsky p-bystritsky

@novikor novikor

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
7 participants
@novikor @magento-engcom-team @VasylShvorak @shikhamis11 @sivaschenko @swnsma @p-bystritsky