Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes-for-product-page-product-in-website-multi-store-view-not-display-proper #21404

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

2.3.0
On product page product in website for multi store view not display proper

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. create another store
  2. select that store for product
  3. display not proper

Expected result (*)

2019-02-22_14-06_chaz kangeroo hoodie

Actual result (*)

2019-02-22_14-05_chaz kangeroo hoodie

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@priti2jcommerce
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce, here is your Magento instance.
Admin access: https://i-21404-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Feb 23, 2019

Hi @priti2jcommerce. Are you sure that setup.css modified within a scope of the current PR is related to the described issue?

@priti2jcommerce
Copy link
Contributor Author

HI @rogyar
Thanks for the update, creating new PR for this, Please check #21426

@rogyar
Copy link
Contributor

rogyar commented Feb 25, 2019

Hi @priti2jcommerce. Thank you, I'm closing this one

@rogyar rogyar closed this Feb 25, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants