Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #21425 Date design change show not correctly value in backend #21443

Merged

Conversation

shikhamis11
Copy link
Member

@shikhamis11 shikhamis11 commented Feb 25, 2019

Fixed #21425 Date design change show not correctly value in backend

Preconditions (*)

  1. Magento 2.3.0
  2. PHP 7.1.17

Steps to reproduce (*)

  1. Go to Admin
  2. Content > Design > Schedule
  3. Add new design change
  4. Fill form with date pick to year 21xx
  5. Go back to edit one more, click on date icon to see issue

Expected result (*)

  1. Show correctly date Ex: 02/04/2100

Actual result (*)

  1. Currently date show 2/4/00
    This happen in interface US locale
    Reproduced on 2.2.8-dev too

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-4377 has been created to process this Pull Request

@ghost
Copy link

ghost commented Mar 4, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants