Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL rewrite fix while product website update using mass action #21462

Merged
merged 1 commit into from
Mar 8, 2019
Merged

URL rewrite fix while product website update using mass action #21462

merged 1 commit into from
Mar 8, 2019

Conversation

AnshuMishra17
Copy link
Contributor

Description

URL rewrite fix while product website update using mass action

Fixed Issues

  1. URL Rewrites are overwritten  #21329: URL Rewrites are overwritten

Manual testing scenarios

  1. Added multiple websites.
  2. Set URL key value at store level for any product.
  3. Added the product in a new website using website update via mass action.
  4. Removed product from a website using website update via mass action.

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@AnshuMishra17 AnshuMishra17 mentioned this pull request Feb 26, 2019
Closed
phoenix128
phoenix128 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AnshuMishra17 ,
thank you for your time and contribution.

@phoenix128 phoenix128 self-assigned this Feb 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128, thank you for the review.
ENGCOM-4386 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 4, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 5, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 8, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 7cacec1 into magento:2.3-develop Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @AnshuMishra17, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 8, 2019
@sidolov
ENGCOM-4386: URL rewrite fix while product website update using mass …
8db78c8 
…action #21462
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoenix128 phoenix128 phoenix128 approved these changes

Assignees

@phoenix128 phoenix128

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: CatalogUrlRewrite Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@AnshuMishra17 @magento-engcom-team @VasylShvorak @phoenix128 @sidolov @nmalevanec