Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update price-bundle.js so that correct tier price is calculated while displaying in bundle product #21469

Merged
merged 6 commits into from
Mar 20, 2019

Conversation

adarshkhatri
Copy link
Contributor

@adarshkhatri adarshkhatri commented Feb 27, 2019

Description (*)

By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".

Fixed Issues (if relevant)

  1. Tier price of simple item not working in Bundle product #21467: Tier price of simple item not working in Bundle product

Manual testing scenarios (*)

  1. Create tier price as per described in above issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".
Issue created: #21467
@magento-engcom-team
Copy link
Contributor

Hi @adarshkhatri. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 27, 2019

CLA assistant check
All committers have signed the CLA.

By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".
@VladimirZaets VladimirZaets self-assigned this Feb 28, 2019
@VladimirZaets
Copy link
Contributor

@adarshkhatri thanks

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4507 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@adarshkhatri thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Mar 20, 2019

Hi @adarshkhatri, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants