Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #21477 sets CURRENT_TIMESTAMP on updated_at fields #21486

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Fix for issue #21477 sets CURRENT_TIMESTAMP on updated_at fields #21486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Integration/etc/db_schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
comment="Oauth consumer"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Creation Time"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we are not allowed to change column default value according to our Backward compatible development guide

Copy link
Member Author

@dverkade dverkade Mar 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidolov how do you expect me to fix this issue? So there is a real issue with these fields, but due to self proclaimed backwards compatibility this can't be fixed.

Then we could just remove these fields as well, because they are never going to work anyway if this fix can't be accepted.

And since there is no 2.4 develop branch yet, I can't do a pull request against that branch as well. A 2.4 develop branch should have been made available right after the release of 2.3 so that new backwards incompatible changes can be done against that branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being reviewed internally now, thanks for your help @dverkade!

comment="Update Time"/>
<column xsi:type="smallint" name="setup_type" padding="5" unsigned="true" nullable="false" identity="false"
default="0" comment="Integration type - manual or config file"/>
Expand Down
10 changes: 5 additions & 5 deletions app/code/Magento/Quote/etc/db_schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
default="0" comment="Quote Id"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Created At"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
comment="Updated At"/>
<column xsi:type="int" name="customer_id" padding="10" unsigned="true" nullable="true" identity="false"
comment="Customer Id"/>
Expand Down Expand Up @@ -218,7 +218,7 @@
default="0" comment="Quote Id"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Created At"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
comment="Updated At"/>
<column xsi:type="int" name="product_id" padding="10" unsigned="true" nullable="true" identity="false"
comment="Product Id"/>
Expand Down Expand Up @@ -322,7 +322,7 @@
default="0" comment="Quote Item Id"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Created At"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
comment="Updated At"/>
<column xsi:type="text" name="applied_rule_ids" nullable="true" comment="Applied Rule Ids"/>
<column xsi:type="text" name="additional_data" nullable="true" comment="Additional Data"/>
Expand Down Expand Up @@ -434,7 +434,7 @@
default="0" comment="Quote Id"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Created At"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
comment="Updated At"/>
<column xsi:type="varchar" name="method" nullable="true" length="255" comment="Method"/>
<column xsi:type="varchar" name="cc_type" nullable="true" length="255" comment="Cc Type"/>
Expand Down Expand Up @@ -470,7 +470,7 @@
default="0" comment="Address Id"/>
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP"
comment="Created At"/>
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="0"
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP"
comment="Updated At"/>
<column xsi:type="varchar" name="carrier" nullable="true" length="255" comment="Carrier"/>
<column xsi:type="varchar" name="carrier_title" nullable="true" length="255" comment="Carrier Title"/>
Expand Down