Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHQ18-1568 Updating UPS endpoint to use https. Http is no longer reli… #21511

Merged
merged 2 commits into from
Mar 30, 2019
Merged

SHQ18-1568 Updating UPS endpoint to use https. Http is no longer reli… #21511

merged 2 commits into from
Mar 30, 2019

Conversation

wsajosh
Copy link
Contributor

@wsajosh wsajosh commented Feb 28, 2019

…ably returning rates

This PR changes the UPS (non XML) endpoint from http to https. UPS are no longer returning rates reliably via a http request.

Test by placing any item into the cart with a weight > 0 and ship to a valid state and zip code such as NY 11705

@magento-engcom-team
Copy link
Contributor

Hi @wsajosh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ihor-sviziev ihor-sviziev self-assigned this Mar 1, 2019
ihor-sviziev
ihor-sviziev requested changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my prev. comment?

@ihor-sviziev @wsajosh
Update app/code/Magento/Ups/Model/Carrier.php
ff94ee1 
Co-Authored-By: wsajosh <joshua.stewart@shipperhq.com>
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4426 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@wsajosh thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VasylShvorak VasylShvorak self-assigned this Mar 27, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 27, 2019
@magento-engcom-team magento-engcom-team merged commit ff94ee1 into magento:2.3-develop Mar 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2019

Hi @wsajosh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 30, 2019
@sivaschenko
ENGCOM-4426: SHQ18-1568 Updating UPS endpoint to use https. Http is n…
84da536 
…o longer reli… #21511
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Component: Ups Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@wsajosh @magento-engcom-team @magento-cicd2 @VasylShvorak @ihor-sviziev @nmalevanec