Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Sitemap filename can't exceed 32 characters #13937 #21530

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20044

Description (*)

The Sitemap filename length validation was not added , hence added \Magento\Framework\Validator\StringLength max 32 length validation for sitemap filename and it will not trim filename exceeding 32 chars. Client side validation in filename field of form is also added to fix this issue 'validate-length maximum-length-32'. Updated saveTest unit test case.

Fixed Issues (if relevant)

  1. magento/magento2#Sitemap filename can't exceed 32 characters #13937: Issue title : Sitemap filename can't exceed 32 characters

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4412 has been created to process this Pull Request

@miguelbalparda
Copy link
Contributor

This is getting out of hands @amol2jcommerce, I keep seeing you grab other's people work and present them as yours while doing backports. I worked on the original PR here and you are in no way associated with the author of #20044

@irajneeshgupta
Copy link
Member

@amol2jcommerce

I am the author of the original PR and kindly don't need to backport other author PR , since author may also want to backport his work.
sorry for inconveniennce but I am closing this PR and consider it as dublicate.
I hope you understand it

Thank you

@ghost
Copy link

ghost commented Mar 2, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants