Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed pagination issue in admin review grid #21537

Merged
merged 4 commits into from
Mar 5, 2019
Merged

[Backport] Fixed pagination issue in admin review grid #21537

merged 4 commits into from
Mar 5, 2019

Conversation

dominicfernando
Copy link
Contributor

Original Pull Request

#21105

Fixed Issues

When entering the number which greater than last page id then trigger/ show the exception in DEV mode and a blank page in production mode

Manual testing scenarios (*)

  1. Goto Marketing -> User Content -> Reviews -> Grid
  2. Enter number grater than last page id

selection_016

Expected Result

Proper admin error message or redirect to the last page

Actual result

Blank page in production mode and show exception in dev mode

Fixed solution

Redirect to the last page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

@magento-engcom-team
Copy link
Contributor

Hi @dominicfernando. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Lib/Frontend Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Mar 1, 2019
@rogyar rogyar self-assigned this Mar 2, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 2, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21537.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4422 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 4, 2019
@soleksii
Copy link

soleksii commented Mar 4, 2019

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 4, 2019
@magento-engcom-team magento-engcom-team merged commit 73b57d4 into magento:2.2-develop Mar 5, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

Hi @dominicfernando, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 5, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants