[Backport] Sitemap filename can't exceed 32 characters #13937

[irajneeshgupta]

Original Pull Request

#20044

Description (*)

The Sitemap filename length validation was not added , hence added \Magento\Framework\Validator\StringLength max 32 length validation for sitemap filename and it will not trim filename exceeding 32 chars. Client side validation in filename field of form is also added to fix this issue 'validate-length maximum-length-32'. Updated saveTest unit test case.

Fixed Issues (if relevant)

1. magento/magento2#Sitemap filename can't exceed 32 characters #13937: Issue title : Sitemap filename can't exceed 32 characters

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

Hi @irajneeshgupta. I believe HttpPostActionInterface is not the case here since this interface was introduced within a scope of 2.3.

[irajneeshgupta]

@rogyar ,
I will modify it .
Thanks.

[rogyar]

Please, check the failing tests and test your solution on 2.2-develop branch manually. Thank you

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4425 has been created to process this Pull Request

[sidolov]

@irajneeshgupta , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[ghost]

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.