Advanced-Search-layout-not-proper

[amol2jcommerce]

Description (*)

Advanced Search layout not proper

Fixed Issues (if relevant)

1. Advanced Search layout not proper #20809: Advanced Search layout not proper

Manual testing scenarios (*)

1. Click Advanced Search link in footer

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[rogyar]

Hi @amol2jcommerce. Thank you for your collaboration. It's looks better now on desktop resolutions. However, if you take a look at iPad (portrait) resolution - the form is quite small. The contact us form has the same issue, so it's not the best example. However, if you check the create account form - it behaves much better in terms of responsive design. Try to compare the result of your solution and the create account form on different resolutions.

[amol2jcommerce]

Hi @rogyar, I updated branch please review.

[sanganinamrata]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @sanganinamrata. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sanganinamrata, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[amol2jcommerce]

Hi @rogyar, I updated branch as per suggestion please review.

[rogyar]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4461 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4461 has been created to process this Pull Request

[ghost]

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.