MFTF / Remove redundant ActionGroups

[lbajsarowicz]

Description (*)

I've removed files that differ from each other by capitalisation:

• Removed 'app/code/Magento/Customer/Test/Mftf/ActionGroup/AssertStoreFrontPasswordAutocompleteOffActionGroup.xml'
• Left 'app/code/Magento/Customer/Test/Mftf/ActionGroup/AssertStorefrontPasswordAutocompleteOffActionGroup.xml'
• Removed 'app/code/Magento/Customer/Test/Mftf/ActionGroup/StoreFrontClickSignInButtonActionGroup.xml'
• Left 'app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontClickSignInButtonActionGroup.xml'

Fixed Issues (if relevant)

• No issues created for that change

Manual testing scenarios (*)

1. Validated manually if these ActionGroups with uppercase StoreFront are not used anywhere:

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[lbajsarowicz]

#magettestfest19

To avoid creating multiple PRs for single set of changes, I've added extra fix for Catalog AdminChangeProductAttributeSet test

[magento-cicd2]

All committers have signed the CLA.

[rogyar]

Please, take a look at app/code/Magento/Customer/Test/Mftf/Test/PasswordAutocompleteOffTest.xml:53. This action group is used within the scope of the mentioned test. Why it's considered as redundant?

[lbajsarowicz]

After reading the PR description you should have noticed that I'm removing duplicated files with different names. The one I'm removing contains StoreFront (uppercase F), the one used in PasswordAutocompleteOffTest is Storefront (lowercase f)

        <actionGroup ref="AssertStorefrontPasswordAutoCompleteOffActionGroup" stepKey="assertStorefrontPasswordAutoCompleteOff"/>

[rogyar]

Please, take a look at app/code/Magento/Customer/Test/Mftf/Test/PasswordAutocompleteOffTest.xml:50. This action group is used within the scope of the mentioned test. Why it's considered as redundant?

[lbajsarowicz]

The same situaiton. I'm removing StoreFront, you are mentioning use of Storefront 🤦‍♂️

[rogyar]

For QA.
The duplicated redundant versions of files are removed within the scope of current PR. It might bring additional troubles if you use case-insensitive filesystem such as AFS. Upon pulling the new changes, all versions of files will be removed (because of GIT+case-insensitive fs particularity). However, if you clone a fresh version, this problem does not occur.
On production environments, in most cases, we have case-sensitive file system, so this change should not have a compatibility issue.
However, the following scenario is good to be tested on a Linux environment:

• Add the fork repository to your existing Magento repository as an additional remote
• Switch and pull the branch with the changes of current PR
• Make sure that you have at least one version of the file: AssertStoreFrontPasswordAutocompleteOffActionGroup.xml or AssertStorefrontPasswordAutocompleteOffActionGroup.xml

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4556 has been created to process this Pull Request

[lbajsarowicz]

I see that one more case-based issue was merged recently:

Cloning into 'm23-dev'...
remote: Enumerating objects: 2099704, done.
remote: Total 2099704 (delta 0), reused 0 (delta 0), pack-reused 2099704
Receiving objects: 100% (2099704/2099704), 496.95 MiB | 6.74 MiB/s, done.
Resolving deltas: 100% (1187902/1187902), done.
Checking out files: 100% (34280/34280), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'app/code/Magento/Customer/Test/Mftf/ActionGroup/AssertStoreFrontPasswordAutocompleteOffActionGroup.xml'
  'app/code/Magento/Customer/Test/Mftf/ActionGroup/AssertStorefrontPasswordAutocompleteOffActionGroup.xml'
  'app/code/Magento/Customer/Test/Mftf/ActionGroup/StoreFrontClickSignInButtonActionGroup.xml'
  'app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontClickSignInButtonActionGroup.xml'
  'app/code/Magento/UrlRewrite/Test/Mftf/MetaData/url_rewrite-meta.xml'
  'app/code/Magento/UrlRewrite/Test/Mftf/Metadata/url_rewrite-meta.xml'

So @rogyar I will add one more fix 🤦‍♂️ to introduced issue

[okolesnyk]

Update: Figured what you mean about StoreFront vs Storefront filename. removed my comments cause I was wrong. Thanks for it.

But we shouldn't delete createUrlRewrite operation cause we use it in test runtime.

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.