-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSI: Add deprecation message to CatalogInventory SPIs #21774
MSI: Add deprecation message to CatalogInventory SPIs #21774
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @maghamed, thank you for the review. |
Notice: QA not applicable |
@@ -15,19 +15,25 @@ | |||
interface StockRegistryProviderInterface | |||
{ | |||
/** | |||
* Get stock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that against DRY? I mean - the method name is descriptive enough.
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Add deprecation information to CatalogInventory SPIs
Fixed Issues (if relevant)
Not applicable
Manual testing scenarios (*)
Not applicable
Contribution checklist (*)