#21734 Error in JS validation rule

[kisroman]

Description (*)

Bug in "validate-per-page-value-list" validation.

Fixed Issues (if relevant)

1. Error in JS validation rule #21734

Manual testing scenarios (*)

1. ...
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @kisroman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[dmytro-ch]

Hi @kisroman,
thank you for your contribution!

The only thing I have a concern about is that we also need to make sure there is no empty value.
However, according to current solution the empty value is condidered as valid.
Could you please fix it?

Thank you!

[kisroman]

Hi @dmytro-ch. I am not sured that this validation should return false if value is empty. For empty value we have other validation as "required".
Also I found Github issue which confirms it #16544.
Thanks :)

[ghost]

@kisroman unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

[dmytro-ch]

@kisroman, thank you for the update.
It does make sense. 👍
In this case, we still need to make sure the grid_per_page_values and list_per_page_values system configs does not contain empty values.
So let's add the proper validation rules into app/code/Magento/Catalog/etc/adminhtml/system.xml.

Thank you!

[kisroman]

@dmytro-ch, agree. Added.

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4546 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

Result:

[ghost]

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.