Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited headings to be more consistent #21782

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

mikeshatch
Copy link
Contributor

Description (*)

I edited the headings to be more consistent with each other.

Contribution checklist (*)

  • [ x] Pull request has a meaningful description of its purpose
  • [ x] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 15, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @mikeshatch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov Mar 15, 2019
@sidolov
Copy link
Contributor

sidolov commented Mar 15, 2019

Hi @mikeshatch , please, sign CLA, otherwise, we can't process your pull request

@mikeshatch
Copy link
Contributor Author

Hi @mikeshatch , please, sign CLA, otherwise, we can't process your pull request

After I made the pull request it asked me to sign it and I did.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4508 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@mikeshatch thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@mikeshatch
Copy link
Contributor Author

@sidolov Thank you, and thanks for the join. I had another proposed edit but am unable to because it's in the description. In the description it says "publically" but it should read "publicly." We're being very technical here. Publically is a variant of publicly, but it does look a bit strange to the eye.

@magento-engcom-team magento-engcom-team merged commit 49bbec4 into magento:2.3-develop Mar 18, 2019
@ghost
Copy link

ghost commented Mar 18, 2019

Hi @mikeshatch, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 18, 2019
@mikeshatch mikeshatch deleted the patch-1 branch March 24, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants