-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#19835 Fix admin header buttons flicker #21791
#19835 Fix admin header buttons flicker #21791
Conversation
Hi @OlehWolf. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@OlehWolf thanks for the pull request! We will be able to process it once you sing the CLA |
@magento-engcom-team give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OlehWolf,
thank you for your contribution!
Could you please check the code review comment?
Thank you!
Hi @dmytro-ch, thank you for the review. |
Hi @OlehWolf, thank you for your contribution! |
Description (*)
Fixed button flicker issue after page load due to re-ordering.
It happens because "floatingHeader" widget, that wraps header buttons in flex container. However during page loading buttons aren't in flexbox wrapper.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)