Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19835 Fix admin header buttons flicker #21791

Merged
merged 1 commit into from
Mar 20, 2019
Merged

#19835 Fix admin header buttons flicker #21791

merged 1 commit into from
Mar 20, 2019

Conversation

Bravarg
Copy link
Contributor

@Bravarg Bravarg commented Mar 16, 2019

Description (*)

Fixed button flicker issue after page load due to re-ordering.
It happens because "floatingHeader" widget, that wraps header buttons in flex container. However during page loading buttons aren't in flexbox wrapper.

Fixed Issues (if relevant)

  1. Admin grid button flicker issue after page load due to re-ordering #19835: Admin grid button flicker issue after page load due to re-ordering

Manual testing scenarios (*)

  1. Open any admin page with more than 1 button in header. For example: Content -> Design -> Configuration and open design configuration of any scope. During page rendering buttons in header are change their order and can be misclicked to wrong button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 16, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @OlehWolf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

@OlehWolf thanks for the pull request! We will be able to process it once you sing the CLA

@dmytro-ch dmytro-ch self-requested a review March 16, 2019 13:16
@dmytro-ch dmytro-ch self-assigned this Mar 16, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21791.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OlehWolf,
thank you for your contribution!

Could you please check the code review comment?

Thank you!

lib/web/mage/backend/floating-header.js Show resolved Hide resolved
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4522 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Result:

after

@ghost
Copy link

ghost commented Mar 20, 2019

Hi @OlehWolf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants