[Backport] Fixed Issue : Search REST API returns wrong total_count #21801

ronak2ram · 2019-03-16T18:27:07Z

Original Pull Request

#21713

Description (*)

I added function for getting total_count of result item.

Fixed Issues (if relevant)

Search REST API returns wrong total_count #17295: Search REST API returns wrong total_count

Manual testing scenarios (*)

Request :

rest/V1/search?searchCriteria[requestName]=quick_search_container&searchCriteria[filterGroups][0][filters][0][field]=search_term&searchCriteria[filterGroups][0][filters][0][conditionType]=like&searchCriteria[filterGroups][0][filters][0][value]=test&searchCriteria[current_page]=1&searchCriteria[page_size]=2

Response :

{
    "items": [
        {
            "id": 126,
            "custom_attributes": [
                {
                    "attribute_code": "score",
                    "value": "73.7660923004150400"
                }
            ]
        },
        {
            "id": 61,
            "custom_attributes": [
                {
                    "attribute_code": "score",
                    "value": "73.7660923004150400"
                }
            ]
        }
    ],
    "aggregations": {
        "buckets": [
            {
                "name": "category_bucket",
                "values": [
                    {
                        "value": "32",
                        "metrics": [
                            "32",
                            "1"
                        ]
                    }
                ]
            },
            {
                "name": "stock_status_bucket",
                "values": []
            },
            {
                "name": "rating_summary_bucket",
                "values": []
            },
            {
                "name": "am_is_new_bucket",
                "values": []
            },
            {
                "name": "am_on_sale_bucket",
                "values": []
            },
            {
                "name": "color_bucket",
                "values": []
            },
            {
                "name": "sub_category_bucket",
                "values": []
            }
        ],
        "bucket_names": [
            "category_bucket",
            "stock_status_bucket",
            "rating_summary_bucket",
            "am_is_new_bucket",
            "am_on_sale_bucket",
            "color_bucket",
            "sub_category_bucket"
        ]
    },
    "search_criteria": {
        "request_name": "quick_search_container",
        "filter_groups": [
            {
                "filters": [
                    {
                        "field": "search_term",
                        "value": "test",
                        "condition_type": "like"
                    }
                ]
            }
        ],
        "page_size": 2,
        "current_page": 1
    },
    "total_count": 9
}

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2019-03-16T18:27:12Z

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

dmytro-ch · 2019-03-17T10:23:45Z

Hi @ronak2ram,
thank you for your contribution!

There are a couple of errors in unit tests with the current solution.

1) Magento\Framework\Search\Test\Unit\Adapter\Mysql\AdapterTest::testQuery
Exception: Notice: Undefined index: total in /home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Test/Unit/Adapter/Mysql/AdapterTest.php on line 171
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:61
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Test/Unit/Adapter/Mysql/AdapterTest.php:171
2) Magento\Framework\Search\Test\Unit\Adapter\Mysql\ResponseFactoryTest::testCreate
Exception: Notice: Undefined index: total in /home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php on line 69
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/App/ErrorHandler.php:61
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php:69
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Test/Unit/Adapter/Mysql/ResponseFactoryTest.php:68
3) Magento\Framework\Search\Test\Unit\SearchResponseBuilderTest::testBuild
TypeError: Return value of Magento\Framework\Search\Response\QueryResponse::getTotal() must be of the type integer, null returned
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Response/QueryResponse.php:81
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/SearchResponseBuilder.php:54
/home/travis/build/magento/magento2/lib/internal/Magento/Framework/Search/Test/Unit/SearchResponseBuilderTest.php:80

Could you please check these issues?

Thank you!

ronak2ram · 2019-03-18T11:09:37Z

Hello @dmytro-ch
Thanks for the review of my PR. I updated the test case and resolved Travis error.
Can you please review again.

ghost · 2019-03-18T17:49:06Z

@ronak2ram unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

dmytro-ch · 2019-03-18T21:07:05Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-03-18T21:07:07Z

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-03-18T21:07:50Z

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21801.instances.magento-community.engineering/admin
Login: admin Password: 123123q

magento-engcom-team · 2019-03-18T21:31:39Z

Hi @dmytro-ch, thank you for the review.
ENGCOM-4529 has been created to process this Pull Request

soleksii · 2019-03-20T07:10:45Z

✔️ QA Passed

Result:

sidolov · 2019-03-20T16:07:47Z

@ronak2ram please, apply latest fixes from the original PR: #21713

sidolov

Fixes from the original PR is needed

ronak2ram · 2019-03-20T18:10:59Z

@sidolov I did all the change from this PR: #21713
Can you please help me to find the remaining changes.

sidolov · 2019-04-04T14:39:10Z

Hi @ronak2ram , changeset from the #21713 contains only 2 files, current PR contains 9 files. Please, make changes from the original PR.

ronak2ram · 2019-04-04T15:57:19Z

Hi @sidolov
I added new files change in this PR because someone added those changes in 2.3-develop(021a953#diff-d3e053570d9a25c8e314852f808fec8a) branch so not need to add in 2.3-develop PR #21713.
But I see in 2.2-develop I do not find this commit 021a953#diff-d3e053570d9a25c8e314852f808fec8a
changes so I added that files and code in current PR which need for the get correct total count.

sidolov · 2019-04-10T18:56:01Z

Hi @ronak2ram , unfortunately, such changes are not acceptable for 2.2 release line due to backward compatibility. Probably you may find a different solution for 2.2 without breaking changes.

ronak2ram · 2019-04-10T19:02:04Z

okay @sidolov, we have to close this PR.

sidolov · 2019-04-10T19:24:21Z

@ronak2ram thank you for collaboration!

m2-assistant · 2019-04-10T19:24:22Z

Hi @ronak2ram, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Resolve Issue : Search REST API returns wrong total_count

858225f

magento-engcom-team added Component: Search Release Line: 2.2 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Mar 16, 2019

dmytro-ch self-requested a review March 17, 2019 09:00

dmytro-ch self-assigned this Mar 17, 2019

dmytro-ch added the Progress: needs update label Mar 17, 2019

Update unit test

7636b54

ronak2ram removed the Progress: needs update label Mar 18, 2019

ghost added the Progress: needs update label Mar 18, 2019

Minor refactoring

954f8fd

dmytro-ch approved these changes Mar 18, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Mar 18, 2019

soleksii self-assigned this Mar 19, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 19, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Mar 20, 2019

nmalevanec self-assigned this Mar 20, 2019

ghost added Progress: accept and removed Progress: extended testing labels Mar 20, 2019

sidolov requested changes Mar 20, 2019

View reviewed changes

ghost assigned sidolov Mar 20, 2019

ghost added Progress: needs update and removed Progress: accept labels Mar 20, 2019

sidolov closed this Apr 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Fixed Issue : Search REST API returns wrong total_count #21801

[Backport] Fixed Issue : Search REST API returns wrong total_count #21801

ronak2ram commented Mar 16, 2019

magento-engcom-team commented Mar 16, 2019

dmytro-ch commented Mar 17, 2019

ronak2ram commented Mar 18, 2019

ghost commented Mar 18, 2019

dmytro-ch commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

soleksii commented Mar 20, 2019

sidolov commented Mar 20, 2019

sidolov left a comment

ronak2ram commented Mar 20, 2019

sidolov commented Apr 4, 2019

ronak2ram commented Apr 4, 2019 •

edited

Loading

sidolov commented Apr 10, 2019

ronak2ram commented Apr 10, 2019

sidolov commented Apr 10, 2019

m2-assistant bot commented Apr 10, 2019

[Backport] Fixed Issue : Search REST API returns wrong total_count #21801

[Backport] Fixed Issue : Search REST API returns wrong total_count #21801

Conversation

ronak2ram commented Mar 16, 2019

Original Pull Request

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Request :

Response :

Contribution checklist (*)

magento-engcom-team commented Mar 16, 2019

dmytro-ch commented Mar 17, 2019

ronak2ram commented Mar 18, 2019

ghost commented Mar 18, 2019

dmytro-ch commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 18, 2019

soleksii commented Mar 20, 2019

sidolov commented Mar 20, 2019

sidolov left a comment

Choose a reason for hiding this comment

ronak2ram commented Mar 20, 2019

sidolov commented Apr 4, 2019

ronak2ram commented Apr 4, 2019 • edited Loading

sidolov commented Apr 10, 2019

ronak2ram commented Apr 10, 2019

sidolov commented Apr 10, 2019

m2-assistant bot commented Apr 10, 2019

ronak2ram commented Apr 4, 2019 •

edited

Loading