Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill data_hash from BULK response with correct data #21815

Merged

Conversation

silyadev
Copy link
Contributor

Description (*)

Added hash for imported data and return it in response
Copy of https://github.com/magento/async-import/pull/63

#23 Fill data_hash from BULK response with correct data
Manual testing scenarios (*)

Make call to bulk API
Check response

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 18, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @silyadev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-requested a review March 19, 2019 08:28
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-4531 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@silyadev thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii
Copy link

✔️ QA Passed

Result:

after

@magento-engcom-team magento-engcom-team merged commit a07956c into magento:2.3-develop Mar 25, 2019
@ghost
Copy link

ghost commented Mar 25, 2019

Hi @silyadev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants