Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning tooltip action on dashboard #21821

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Mar 18, 2019

Description (*)

The tooltip action field is not aligned on the Magento's dashboard first screen, as you can see below.

Before

Screenshot 2019-03-18 10 09 05

After

Screenshot 2019-03-18 10 09 11

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafaelstz, thanks for collaboration. I don't see any changes on the screenshot and in general, you change styles for all backend field. Do you check behavior on the other fields that use this class?

@rafaelstz
Copy link
Member Author

Hi @VladimirZaets,

The issue is the unaligned element that has extra 20px left, I fixed it to keep it in the same distance as the other side of the component, yes I checked the behavior.

Screenshot 2019-03-20 14 59 13

Screenshot 2019-03-20 15 02 24

Screenshot 2019-03-20 15 10 06

@VladimirZaets
Copy link
Contributor

@rafaelstz thanks

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4668 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 10, 2019
@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit ad65812 into magento:2.3-develop Apr 15, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants