-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] magento/magento2#12396: Total Amount cart rule without tax #21845
[Backport] magento/magento2#12396: Total Amount cart rule without tax #21845
Conversation
…on type to give user opportunity to choose the configuration.
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
Hi @eduard13, thank you for your contribution! |
Original Pull Request
#21288
Added new condition type to give user opportunity to choose the configuration.
Description (*)
I thought about the fix of what should be fixed in here. But I guess it's up to the user what to choose and what conditions to have to apply the rule.
I decided to add new Cart Attribute to Subtotal (Excl. Tax) which is basically one of the totals base_subtotal_with_discount
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)