Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] magento/magento2#12396: Total Amount cart rule without tax #21845

Merged

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#21288
Added new condition type to give user opportunity to choose the configuration.

Description (*)

I thought about the fix of what should be fixed in here. But I guess it's up to the user what to choose and what conditions to have to apply the rule.
I decided to add new Cart Attribute to Subtotal (Excl. Tax) which is basically one of the totals base_subtotal_with_discount

Fixed Issues (if relevant)

  1. magento/magento2#<12396>: "Total Amount" cart rule without tax

Manual testing scenarios (*)

  1. Go to the Admin Panel. Open Marketing->Cart Price Rules
  2. Add new rule or edit existing one
  3. Under the Condition tab you will be able to see new Configuration Subtotal (Excl. Tax).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: SalesRule Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 20, 2019
@eduard13 eduard13 requested a review from dmytro-ch March 20, 2019 05:11
@dmytro-ch dmytro-ch self-assigned this Mar 20, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21845.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4540 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 24, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SalesRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants