-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] fix #21750 remove translation of product attribute label #21864
[Backport] fix #21750 remove translation of product attribute label #21864
Conversation
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @orlangur, thank you for the review. |
Hi @mage2pratik ! I've checked PR and looks like that these changes doesn't solve the problem. Thanks! |
Created Backport #21872 |
✔️ QA Passed |
Hi @mage2pratik, thank you for your contribution! |
Original Pull Request
#21751
Description (*)
Removed translation of attribute label
Fixed Issues (if relevant)
Manual testing scenarios (*)
Add product attribute into product page.
Add store specific label
add same phrase into translation file
Expected result ()
Attribute label is not translated and kept as set in admin (store specific label)
Actual result ()
Attribute label is translated
Contribution checklist (*)