Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact us layout in I-pad not proper #21896

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Contact us layout in I-pad not proper

Preconditions (*)

  1. Magento 2.3, 2.2
  2. Contact us layout in I-pad not proper

Steps to reproduce (*)

  1. Open contact us form in I-pad

Expected result (*)

  1. If you check the create account form, orders and returns form, advance search form (forms in I-pad views) - it behaves much better in terms of responsive design.

Contact_Us_1

Actual result (*)

  1. If you take a look at iPad resolution - the form is quite small

Contact_Us_2

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor

Karlasa commented Mar 22, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21896.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will make form overflow on mobile devices.
Screen Shot 2019-03-22 at 15 57 34

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your new Magento instance.
Admin access: https://pr-21896.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@amol2jcommerce
Copy link
Contributor Author

Hi @Karlasa Fixed mention issue on mobile devices and update branch.
please review once.

@amol2jcommerce amol2jcommerce requested a review from Karlasa March 22, 2019 14:08
Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just?

`
//
// Desktop
// _____________________________________________

.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {
.contact-index-index .column:not(.sidebar-additional) .form.contact {
min-width: 600px;
width: 50%;
}
}
`
basically as same as other forms under Magento_Customer

@amol2jcommerce
Copy link
Contributor Author

Hi @Karlasa, I update branch please review.

@amol2jcommerce amol2jcommerce requested a review from Karlasa March 25, 2019 05:28
@Karlasa
Copy link
Contributor

Karlasa commented Mar 26, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21896.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4580 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit 412a51d into magento:2.3-develop Apr 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 5, 2019
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants