Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unwanted interface implementation #22002

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Removed unwanted interface implementation #22002

merged 2 commits into from
Apr 11, 2019

Conversation

vishal-7037
Copy link
Contributor

Description (*)

Fixed 404 error issue on dashboard at Magento admin when clicked on Most viewed products tab

Fixed Issues (if relevant)

  1. Magento backend dashboard: Most viewed products tabs gives 404 error in console. #22001: Magento backend dashboard: Most viewed products tabs gives 404 error in console.

Manual testing scenarios (*)

  1. Login to Magento admin
  2. Click on Most viewed products tabs, a spinner will be loading continuously.
  3. Open developer console, you will get 404 error.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vishal-7037. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Mar 28, 2019
orlangur
orlangur approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmalevanec could you please look into this, change was introduced in 5103b8e

@ghost ghost assigned orlangur Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4601 has been created to process this Pull Request

@nmalevanec
Copy link
Contributor

@nmalevanec could you please look into this, change was introduced in 5103b8e

@orlangur, wrong interface has been introduced by mistake. Have changed it to correct one 192833f

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4601 has been created to process this Pull Request

@nmalevanec nmalevanec force-pushed the admin-dashboard-product-tab branch from 44d4836 to 6e94cd0 Compare April 2, 2019 08:21
orlangur
orlangur requested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmalevanec could you please squash your commits into a single one?

@nmalevanec nmalevanec force-pushed the admin-dashboard-product-tab branch from 6e94cd0 to 8a98f20 Compare April 3, 2019 07:23
@nmalevanec
Copy link
Contributor

@orlangur, done.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4601 has been created to process this Pull Request

@nmalevanec nmalevanec self-assigned this Apr 3, 2019
@soleksii soleksii self-assigned this Apr 8, 2019
@soleksii
Copy link

soleksii commented Apr 8, 2019

✔️ QA Passed

Before:

before

After:

after

@magento-engcom-team magento-engcom-team mentioned this pull request Apr 11, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 8a98f20 into magento:2.3-develop Apr 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @vishal-7037, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 11, 2019
@sidolov
ENGCOM-4601: Removed unwanted interface implementation #22002
247388e
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@rogyar rogyar

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Component: Backend Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@vishal-7037 @magento-engcom-team @nmalevanec @soleksii @orlangur @rogyar